Commit 254e8fb5 authored Jul 02, 2025 by Petr Mladek

printk: ringbuffer: Explain why the KUnit test ignores failed writes



The KUnit test ignores prb_reserve() failures on purpose. It tries
to push the ringbuffer beyond limits.

Note that it is a know problem that writes might fail in this situation.
printk() tries to prevent this problem by:

  + allocating big enough data buffer, see log_buf_add_cpu().

  + allocating enough descriptors by using small enough average
    record, see PRB_AVGBITS.

  + storing the record with disabled interrupts, see vprintk_store().

Also the amount of printk() messages is always somehow bound in
practice. And they are serialized when they are printed from
many CPUs on purpose, for example, when printing backtraces.

Reviewed-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Link: https://patch.msgid.link/20250702095157.110916-2-pmladek@suse.com


Signed-off-by: Petr Mladek <pmladek@suse.com>

parent 5ea2bcdf

kernel/printk/printk_ringbuffer_kunit_test.c

+13 −0

Original line number	Diff line number	Diff line
		@@ -123,6 +123,19 @@ static int prbtest_writer(void *data)
		/* specify the text sizes for reservation */
		prb_rec_init_wr(&r, record_size);

		/*
		* Reservation can fail if:
		*
		* - No free descriptor is available.
		* - The buffer is full, and the oldest record is reserved
		* but not yet committed.
		*
		* It actually happens in this test because all CPUs are trying
		* to write an unbounded number of messages in a tight loop.
		* These failures are intentionally ignored because this test
		* focuses on races, ringbuffer consistency, and pushing system
		* usability limits.
		*/
		if (prb_reserve(&e, tr->test_data->ringbuffer, &r)) {
		r.info->text_len = record_size;