Commit 25facbab authored by Geraldo Nascimento's avatar Geraldo Nascimento Committed by Vinod Koul
Browse files

phy: rockchip-pcie: Properly disable TEST_WRITE strobe signal 



pcie_conf is used to touch TEST_WRITE strobe signal. This signal should
be enabled, a little time waited, and then disabled. Current code clearly
was copy-pasted and never disables the strobe signal. Adjust the define.
While at it, remove PHY_CFG_RD_MASK which has been unused since
64cdc036 ("phy: rockchip-pcie: remove unused phy_rd_cfg function").

Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: default avatarGeraldo Nascimento <geraldogabriel@gmail.com>
Link: https://lore.kernel.org/r/d514d5d5627680caafa8b7548cbdfee4307f5440.1751322015.git.geraldogabriel@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent c3fe7071

drivers/phy/rockchip/phy-rockchip-pcie.c

+1 −2
Original line number Diff line number Diff line
@@ -30,9 +30,8 @@ 
#define PHY_CFG_ADDR_SHIFT    1

#define PHY_CFG_DATA_MASK     0xf

#define PHY_CFG_ADDR_MASK     0x3f

#define PHY_CFG_RD_MASK       0x3ff

#define PHY_CFG_WR_ENABLE     1

#define PHY_CFG_WR_DISABLE    1

#define PHY_CFG_WR_DISABLE    0

#define PHY_CFG_WR_SHIFT      0

#define PHY_CFG_WR_MASK       1

#define PHY_CFG_PLL_LOCK      0x10