Commit 26900989 authored by Maciej Fijalkowski's avatar Maciej Fijalkowski Committed by Alexei Starovoitov
Browse files

xsk: recycle buffer in case Rx queue was full 



Add missing xsk_buff_free() call when __xsk_rcv_zc() failed to produce
descriptor to XSK Rx queue.

Fixes: 24ea5012 ("xsk: support mbuf on ZC RX")
Acked-by: default avatarMagnus Karlsson <magnus.karlsson@intel.com>
Signed-off-by: default avatarMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Link: https://lore.kernel.org/r/20240124191602.566724-2-maciej.fijalkowski@intel.com


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 1732ebc4

net/xdp/xsk.c

+8 −4
Original line number Diff line number Diff line
@@ -167,8 +167,10 @@ static int xsk_rcv_zc(struct xdp_sock *xs, struct xdp_buff *xdp, u32 len) 
		contd = XDP_PKT_CONTD;



	err = __xsk_rcv_zc(xs, xskb, len, contd);

	if (err || likely(!frags))

		goto out;

	if (err)

		goto err;

	if (likely(!frags))

		return 0;



	xskb_list = &xskb->pool->xskb_list;

	list_for_each_entry_safe(pos, tmp, xskb_list, xskb_list_node) {
@@ -177,11 +179,13 @@ static int xsk_rcv_zc(struct xdp_sock *xs, struct xdp_buff *xdp, u32 len) 
		len = pos->xdp.data_end - pos->xdp.data;

		err = __xsk_rcv_zc(xs, pos, len, contd);

		if (err)

			return err;

			goto err;

		list_del(&pos->xskb_list_node);

	}



out:

	return 0;

err:

	xsk_buff_free(xdp);

	return err;

}