Commit 26dd44a4 authored by Pengjie Zhang's avatar Pengjie Zhang Committed by Chanwoo Choi
Browse files

PM / devfreq: hisi: Fix potential UAF in OPP handling 



Ensure all required data is acquired before calling dev_pm_opp_put(opp)
to maintain correct resource acquisition and release order.

Fixes: 7da2fdaa ("PM / devfreq: Add HiSilicon uncore frequency scaling driver")
Signed-off-by: default avatarPengjie Zhang <zhangpengjie2@huawei.com>
Reviewed-by: default avatarJie Zhan <zhanjie9@hisilicon.com>
Acked-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Link: https://patchwork.kernel.org/project/linux-pm/patch/20250915062135.748653-1-zhangpengjie2@huawei.com/
parent 447c4e83

drivers/devfreq/hisi_uncore_freq.c

+2 −1
Original line number Diff line number Diff line
@@ -264,10 +264,11 @@ static int hisi_uncore_target(struct device *dev, unsigned long *freq, 
		dev_err(dev, "Failed to get opp for freq %lu hz\n", *freq);

		return PTR_ERR(opp);

	}

	dev_pm_opp_put(opp);



	data = (u32)(dev_pm_opp_get_freq(opp) / HZ_PER_MHZ);



	dev_pm_opp_put(opp);



	return hisi_uncore_cmd_send(uncore, HUCF_PCC_CMD_SET_FREQ, &data);

}