Commit 27405096 authored by Christian König's avatar Christian König Committed by Alex Deucher
Browse files

drm/amdgpu: revert "Implement new dummy vram manager" 



This is should be unnecessary since a VRAM manager isn't mandatory in
the first place.

It could be that we have some missing checks inside AMDGPU or TTM but
those should then be fixed instead of worked around like that.

Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Acked-by: default avatarFelix Kuehling <felix.kuehling@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a9273da0

drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

+9 −6
Original line number Diff line number Diff line
@@ -1943,12 +1943,14 @@ int amdgpu_ttm_init(struct amdgpu_device *adev) 
	}

	adev->mman.initialized = true;



	if (!adev->gmc.is_app_apu) {

		/* Initialize VRAM pool with all of VRAM divided into pages */

		r = amdgpu_vram_mgr_init(adev);

		if (r) {

			dev_err(adev->dev, "Failed initializing VRAM heap.\n");

			return r;

		}

	}



	/* Change the size here instead of the init above so only lpfn is affected */

	amdgpu_ttm_set_buffer_funcs_status(adev, false);
@@ -2162,6 +2164,7 @@ void amdgpu_ttm_fini(struct amdgpu_device *adev) 
		drm_dev_exit(idx);

	}



	if (!adev->gmc.is_app_apu)

		amdgpu_vram_mgr_fini(adev);

	amdgpu_gtt_mgr_fini(adev);

	amdgpu_preempt_mgr_fini(adev);

drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c

+4 −57
Original line number Diff line number Diff line
@@ -425,45 +425,6 @@ int amdgpu_vram_mgr_query_address_block_info(struct amdgpu_vram_mgr *mgr, 
	return ret;

}



static void amdgpu_dummy_vram_mgr_debug(struct ttm_resource_manager *man,

				  struct drm_printer *printer)

{

	DRM_DEBUG_DRIVER("Dummy vram mgr debug\n");

}



static bool amdgpu_dummy_vram_mgr_compatible(struct ttm_resource_manager *man,

				       struct ttm_resource *res,

				       const struct ttm_place *place,

				       size_t size)

{

	DRM_DEBUG_DRIVER("Dummy vram mgr compatible\n");

	return false;

}



static bool amdgpu_dummy_vram_mgr_intersects(struct ttm_resource_manager *man,

				       struct ttm_resource *res,

				       const struct ttm_place *place,

				       size_t size)

{

	DRM_DEBUG_DRIVER("Dummy vram mgr intersects\n");

	return true;

}



static void amdgpu_dummy_vram_mgr_del(struct ttm_resource_manager *man,

				struct ttm_resource *res)

{

	DRM_DEBUG_DRIVER("Dummy vram mgr deleted\n");

}



static int amdgpu_dummy_vram_mgr_new(struct ttm_resource_manager *man,

			       struct ttm_buffer_object *tbo,

			       const struct ttm_place *place,

			       struct ttm_resource **res)

{

	DRM_DEBUG_DRIVER("Dummy vram mgr new\n");

	return -ENOSPC;

}



/**

 * amdgpu_vram_mgr_new - allocate new ranges

 *
@@ -932,14 +893,6 @@ static void amdgpu_vram_mgr_debug(struct ttm_resource_manager *man, 
	mutex_unlock(&mgr->lock);

}



static const struct ttm_resource_manager_func amdgpu_dummy_vram_mgr_func = {

	.alloc	= amdgpu_dummy_vram_mgr_new,

	.free	= amdgpu_dummy_vram_mgr_del,

	.intersects = amdgpu_dummy_vram_mgr_intersects,

	.compatible = amdgpu_dummy_vram_mgr_compatible,

	.debug	= amdgpu_dummy_vram_mgr_debug

};



static const struct ttm_resource_manager_func amdgpu_vram_mgr_func = {

	.alloc	= amdgpu_vram_mgr_new,

	.free	= amdgpu_vram_mgr_del,
@@ -973,16 +926,10 @@ int amdgpu_vram_mgr_init(struct amdgpu_device *adev) 
	INIT_LIST_HEAD(&mgr->allocated_vres_list);

	mgr->default_page_size = PAGE_SIZE;



	if (!adev->gmc.is_app_apu) {

	man->func = &amdgpu_vram_mgr_func;



	err = drm_buddy_init(&mgr->mm, man->size, PAGE_SIZE);

	if (err)

		return err;

	} else {

		man->func = &amdgpu_dummy_vram_mgr_func;

		DRM_INFO("Setup dummy vram mgr\n");

	}



	ttm_set_driver_manager(&adev->mman.bdev, TTM_PL_VRAM, &mgr->manager);

	ttm_resource_manager_set_used(man, true);