Commit 2812b5ad authored by Nicholas Kazlauskas's avatar Nicholas Kazlauskas Committed by Alex Deucher
Browse files

drm/amd/display: Wait for mailbox ready when powering up DMCUB 



[Why]
Otherwise we can send commands too early and they don't execute until
the next command is sent.

[How]
Check the extra status bit when polling for HW powered up.

Reviewed-by: default avatarCharlene Liu <charlene.liu@amd.com>
Acked-by: default avatarTom Chung <chiahsuan.chung@amd.com>
Signed-off-by: default avatarNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 05d3dfd3

drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c

+11 −2
Original line number Diff line number Diff line
@@ -791,11 +791,20 @@ enum dmub_status dmub_srv_cmd_execute(struct dmub_srv *dmub) 


bool dmub_srv_is_hw_pwr_up(struct dmub_srv *dmub)

{

	union dmub_fw_boot_status status;



	if (!dmub->hw_funcs.is_hw_powered_up)

		return true;



	return dmub->hw_funcs.is_hw_powered_up(dmub) &&

		dmub->hw_funcs.is_hw_init(dmub);

	if (!dmub->hw_funcs.is_hw_powered_up(dmub))

		return false;



	if (!dmub->hw_funcs.is_hw_init(dmub))

		return false;



	status = dmub->hw_funcs.get_fw_status(dmub);



	return status.bits.dal_fw && status.bits.mailbox_rdy;

}



enum dmub_status dmub_srv_wait_for_hw_pwr_up(struct dmub_srv *dmub,