Commit 282f3952 authored by Qasim Ijaz's avatar Qasim Ijaz Committed by Ingo Molnar
Browse files

x86/mm: Replace open-coded gap bounding with clamp() 



Rather than manually bounding gap between gap_min and gap_max,
use the well-known clamp() macro to make the code easier to read.

Signed-off-by: default avatarQasim Ijaz <qasdev00@gmail.com>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20250215125249.10729-1-qasdev00@gmail.com
parent 81256a50

arch/x86/mm/mmap.c

+1 −8
Original line number Diff line number Diff line
@@ -84,7 +84,6 @@ static unsigned long mmap_base(unsigned long rnd, unsigned long task_size, 
{

	unsigned long gap = rlim_stack->rlim_cur;

	unsigned long pad = stack_maxrandom_size(task_size) + stack_guard_gap;

	unsigned long gap_min, gap_max;



	/* Values close to RLIM_INFINITY can overflow. */

	if (gap + pad > gap)
@@ -94,13 +93,7 @@ static unsigned long mmap_base(unsigned long rnd, unsigned long task_size, 
	 * Top of mmap area (just below the process stack).

	 * Leave an at least ~128 MB hole with possible stack randomization.

	 */

	gap_min = SIZE_128M;

	gap_max = (task_size / 6) * 5;



	if (gap < gap_min)

		gap = gap_min;

	else if (gap > gap_max)

		gap = gap_max;

	gap = clamp(gap, SIZE_128M, (task_size / 6) * 5);



	return PAGE_ALIGN(task_size - gap - rnd);

}