Commit 28a9972e authored by Nicolas Escande's avatar Nicolas Escande Committed by Jeff Johnson
Browse files

wifi: ath12k: fix skb_ext_desc leak in ath12k_dp_tx() error path 



When vlan support was added, we missed that when
ath12k_dp_prepare_htt_metadata() returns an error we also need to free
the skb holding the metadata before going on with the cleanup process.

Compile tested only.

Fixes: 26dd8ccd ("wifi: ath12k: dynamic VLAN support")
Signed-off-by: default avatarNicolas Escande <nico.escande@gmail.com>
Reviewed-by: default avatarAditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
Link: https://patch.msgid.link/20250122160112.3234558-1-nico.escande@gmail.com


Signed-off-by: default avatarJeff Johnson <jeff.johnson@oss.qualcomm.com>
parent a93185b7

drivers/net/wireless/ath/ath12k/dp_tx.c

+1 −0
Original line number Diff line number Diff line
@@ -398,6 +398,7 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_link_vif *arvif, 
			if (ret < 0) {

				ath12k_dbg(ab, ATH12K_DBG_DP_TX,

					   "Failed to add HTT meta data, dropping packet\n");

				kfree_skb(skb_ext_desc);

				goto fail_unmap_dma;

			}

		}