Commit 28f961f9 authored Jun 06, 2024 by Dan Carpenter Committed by David S. Miller Jun 09, 2024

dmaengine: ti: k3-udma-glue: clean up return in k3_udma_glue_rx_get_irq()



Currently the k3_udma_glue_rx_get_irq() function returns either negative
error codes or zero on error.  Generally, in the kernel, zero means
success so this be confusing and has caused bugs in the past.  Also the
"tx" version of this function only returns negative error codes.  Let's
clean this "rx" function so both functions match.

This patch has no effect on runtime.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Acked-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 924ee531

drivers/dma/ti/k3-udma-glue.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1531,6 +1531,9 @@ int k3_udma_glue_rx_get_irq(struct k3_udma_glue_rx_channel *rx_chn,
		flow->virq = k3_ringacc_get_ring_irq_num(flow->ringrx);
		}

		if (!flow->virq)
		return -ENXIO;

		return flow->virq;
		}
		EXPORT_SYMBOL_GPL(k3_udma_glue_rx_get_irq);

drivers/net/ethernet/ti/am65-cpsw-nuss.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2424,10 +2424,10 @@ static int am65_cpsw_nuss_init_rx_chns(struct am65_cpsw_common *common)

		rx_chn->irq = k3_udma_glue_rx_get_irq(rx_chn->rx_chn, i);

		if (rx_chn->irq <= 0) {
		if (rx_chn->irq < 0) {
		dev_err(dev, "Failed to get rx dma irq %d\n",
		rx_chn->irq);
		ret = -ENXIO;
		ret = rx_chn->irq;
		goto err;
		}
		}

drivers/net/ethernet/ti/icssg/icssg_common.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -440,9 +440,7 @@ int prueth_init_rx_chns(struct prueth_emac *emac,
		fdqring_id = k3_udma_glue_rx_flow_get_fdq_id(rx_chn->rx_chn,
		i);
		ret = k3_udma_glue_rx_get_irq(rx_chn->rx_chn, i);
		if (ret <= 0) {
		if (!ret)
		ret = -ENXIO;
		if (ret < 0) {
		netdev_err(ndev, "Failed to get rx dma irq");
		goto fail;
		}