Commit 29b8e94d authored by Yang Jihong's avatar Yang Jihong Committed by Namhyung Kim
Browse files

perf lock contention: Fix a build error on 32-bit 



Fix a build error on 32-bit system:

  util/bpf_lock_contention.c: In function 'lock_contention_get_name':
  util/bpf_lock_contention.c:253:50: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'u64 {aka long long unsigned int}' [-Werror=format=]
     snprintf(name_buf, sizeof(name_buf), "cgroup:%lu", cgrp_id);
                                                  ~~^
                                                  %llu
  cc1: all warnings being treated as errors

Fixes: d0c502e4 ("perf lock contention: Prepare to handle cgroups")
Signed-off-by: default avatarYang Jihong <yangjihong1@huawei.com>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: avagin@google.com
Cc: daniel.diaz@linaro.org
Link: https://lore.kernel.org/r/20231118024858.1567039-3-yangjihong1@huawei.com


Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent a6dda77a

tools/perf/util/bpf_lock_contention.c

+2 −1
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ 
#include <linux/zalloc.h>

#include <linux/string.h>

#include <bpf/bpf.h>

#include <inttypes.h>



#include "bpf_skel/lock_contention.skel.h"

#include "bpf_skel/lock_data.h"
@@ -250,7 +251,7 @@ static const char *lock_contention_get_name(struct lock_contention *con, 
		if (cgrp)

			return cgrp->name;



		snprintf(name_buf, sizeof(name_buf), "cgroup:%lu", cgrp_id);

		snprintf(name_buf, sizeof(name_buf), "cgroup:%" PRIu64 "", cgrp_id);

		return name_buf;

	}