Commit 2a14e91b authored by Matt Johnston's avatar Matt Johnston Committed by Jakub Kicinski
Browse files

mctp i2c: initialise event handler read bytes 



Set a 0xff value for i2c reads of an mctp-i2c device. Otherwise reads
will return "val" from the i2c bus driver. For i2c-aspeed and
i2c-npcm7xx that is a stack uninitialised u8.

Tested with "i2ctransfer -y 1 r10@0x34" where 0x34 is a mctp-i2c
instance, now it returns all 0xff.

Fixes: f5b8abf9 ("mctp i2c: MCTP I2C binding driver")
Signed-off-by: default avatarMatt Johnston <matt@codeconstruct.com.au>
Link: https://patch.msgid.link/20260113-mctp-read-fix-v1-1-70c4b59c741c@codeconstruct.com.au


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 74ecff77

drivers/net/mctp/mctp-i2c.c

+3 −0
Original line number Diff line number Diff line
@@ -243,7 +243,10 @@ static int mctp_i2c_slave_cb(struct i2c_client *client, 


	switch (event) {

	case I2C_SLAVE_READ_REQUESTED:

	case I2C_SLAVE_READ_PROCESSED:

		/* MCTP I2C transport only uses writes */

		midev->rx_pos = 0;

		*val = 0xff;

		break;

	case I2C_SLAVE_WRITE_RECEIVED:

		if (midev->rx_pos < MCTP_I2C_BUFSZ) {