Commit 2a26a11e authored by Peter Wang's avatar Peter Wang Committed by Martin K. Petersen
Browse files

scsi: ufs: core: Fix MCQ mode dev command timeout 



When a dev command times out in MCQ mode, a successfully cleared command
should cause a retry. However, because we currently return 0, the caller
considers the command a success which causes the following error to be
logged: "Invalid offset 0x0 in descriptor IDN 0x9, length 0x0".

Retry if clearing the command was successful.

Signed-off-by: default avatarPeter Wang <peter.wang@mediatek.com>
Link: https://lore.kernel.org/r/20240328111244.3599-1-peter.wang@mediatek.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent e675a4fd

drivers/ufs/core/ufshcd.c

+3 −1
Original line number Diff line number Diff line
@@ -3217,7 +3217,9 @@ static int ufshcd_wait_for_dev_cmd(struct ufs_hba *hba, 


		/* MCQ mode */

		if (is_mcq_enabled(hba)) {

			err = ufshcd_clear_cmd(hba, lrbp->task_tag);

			/* successfully cleared the command, retry if needed */

			if (ufshcd_clear_cmd(hba, lrbp->task_tag) == 0)

				err = -EAGAIN;

			hba->dev_cmd.complete = NULL;

			return err;

		}