Commit 2aa35b24 authored by Qianfeng Rong's avatar Qianfeng Rong Committed by Jason Gunthorpe
Browse files

RDMA/erdma: Use vcalloc() instead of vzalloc() 

Replace vzalloc() with vcalloc() in vmalloc_to_dma_addrs().  As noted in
the kernel documentation [1], open-coded multiplication in allocator
arguments is discouraged because it can lead to integer overflow.

Use vcalloc() to gain built-in overflow protection, making memory
allocation safer when calculating allocation size compared to explicit
multiplication.

[1]: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Link: https://patch.msgid.link/r/20250821072209.510348-1-rongqianfeng@vivo.com


Signed-off-by: default avatarQianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: default avatarCheng Xu <chengyou@linux.alibaba.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 08aae786

drivers/infiniband/hw/erdma/erdma_verbs.c

+1 −1
Original line number Diff line number Diff line
@@ -671,7 +671,7 @@ static u32 vmalloc_to_dma_addrs(struct erdma_dev *dev, dma_addr_t **dma_addrs, 


	npages = (PAGE_ALIGN((u64)buf + len) - PAGE_ALIGN_DOWN((u64)buf)) >>

		 PAGE_SHIFT;

	pg_dma = vzalloc(npages * sizeof(dma_addr_t));

	pg_dma = vcalloc(npages, sizeof(*pg_dma));

	if (!pg_dma)

		return 0;