Commit 2ac538e4 authored Jan 06, 2025 by He Wang Committed by Steve French Jan 07, 2025

ksmbd: fix unexpectedly changed path in ksmbd_vfs_kern_path_locked



When `ksmbd_vfs_kern_path_locked` met an error and it is not the last
entry, it will exit without restoring changed path buffer. But later this
buffer may be used as the filename for creation.

Fixes: c5a709f0 ("ksmbd: handle caseless file creation")
Signed-off-by: He Wang <xw897002528@gmail.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent c7f3cd1b

fs/smb/server/vfs.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1264,6 +1264,8 @@ int ksmbd_vfs_kern_path_locked(struct ksmbd_work work, char name,
		filepath,
		flags,
		path);
		if (!is_last)
		next[0] = '/';
		if (err)
		goto out2;
		else if (is_last)
		@@ -1271,7 +1273,6 @@ int ksmbd_vfs_kern_path_locked(struct ksmbd_work work, char name,
		path_put(parent_path);
		parent_path = path;

		next[0] = '/';
		remain_len -= filename_len + 1;
		}