Commit 2bf66e66 authored by Michael Ellerman's avatar Michael Ellerman Committed by Madhavan Srinivasan
Browse files

selftests/powerpc: Fix argument order to timer_sub() 



Commit c814bf95 ("powerpc/selftests: Use timersub() for
gettimeofday()"), got the order of arguments to timersub() wrong,
leading to a negative time delta being reported, eg:

  test: gettimeofday
  tags: git_version:v6.12-rc5-409-gdddf291c3030
  time = -3.297781
  success: gettimeofday

The correct order is minuend, subtrahend, which in this case is end,
start. Which gives:

  test: gettimeofday
  tags: git_version:v6.12-rc5-409-gdddf291c3030-dirty
  time = 3.300650
  success: gettimeofday

Fixes: c814bf95 ("powerpc/selftests: Use timersub() for gettimeofday()")
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarMadhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20241218114347.428108-1-mpe@ellerman.id.au
parent 200f22fa

tools/testing/selftests/powerpc/benchmarks/gettimeofday.c

+1 −1
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ static int test_gettimeofday(void) 
		gettimeofday(&tv_end, NULL);

	}



	timersub(&tv_start, &tv_end, &tv_diff);

	timersub(&tv_end, &tv_start, &tv_diff);



	printf("time = %.6f\n", tv_diff.tv_sec + (tv_diff.tv_usec) * 1e-6);