Commit 2cbece60 authored by Zhang Zekun's avatar Zhang Zekun Committed by Jakub Kicinski
Browse files

net: hns3: Use ARRAY_SIZE() to improve readability 



There is a helper function ARRAY_SIZE() to help calculating the
u32 array size, and we don't need to do it mannually. So, let's
use ARRAY_SIZE() to calculate the array size, and improve the code
readability.

Signed-off-by: default avatarZhang Zekun <zhangzekun11@huawei.com>
Reviewed-by: default avatarJijie <Shao&lt;shaojijie@huawei.com>
Link: https://patch.msgid.link/20240818052518.45489-1-zhangzekun11@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 555e5531

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_regs.c

+4 −4
Original line number Diff line number Diff line
@@ -134,17 +134,17 @@ void hclgevf_get_regs(struct hnae3_handle *handle, u32 *version, 
	reg += hclgevf_reg_get_header(reg);



	/* fetching per-VF registers values from VF PCIe register space */

	reg_um = sizeof(cmdq_reg_addr_list) / sizeof(u32);

	reg_um = ARRAY_SIZE(cmdq_reg_addr_list);

	reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_CMDQ, reg_um, reg);

	for (i = 0; i < reg_um; i++)

		*reg++ = hclgevf_read_dev(&hdev->hw, cmdq_reg_addr_list[i]);



	reg_um = sizeof(common_reg_addr_list) / sizeof(u32);

	reg_um = ARRAY_SIZE(common_reg_addr_list);

	reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_COMMON, reg_um, reg);

	for (i = 0; i < reg_um; i++)

		*reg++ = hclgevf_read_dev(&hdev->hw, common_reg_addr_list[i]);



	reg_um = sizeof(ring_reg_addr_list) / sizeof(u32);

	reg_um = ARRAY_SIZE(ring_reg_addr_list);

	for (j = 0; j < hdev->num_tqps; j++) {

		reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_RING, reg_um, reg);

		for (i = 0; i < reg_um; i++)
@@ -153,7 +153,7 @@ void hclgevf_get_regs(struct hnae3_handle *handle, u32 *version, 
						  HCLGEVF_RING_REG_OFFSET * j);

	}



	reg_um = sizeof(tqp_intr_reg_addr_list) / sizeof(u32);

	reg_um = ARRAY_SIZE(tqp_intr_reg_addr_list);

	for (j = 0; j < hdev->num_msi_used - 1; j++) {

		reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_TQP_INTR, reg_um, reg);

		for (i = 0; i < reg_um; i++)