Commit 2d0b80c3 authored by Brett Creeley's avatar Brett Creeley Committed by Jakub Kicinski
Browse files

ionic: Don't check null when calling vfree() 



vfree() checks for null internally, so there's no need to
check in the caller. So, always vfree() on variables
allocated with valloc(). If the variables are never
alloc'd vfree() is still safe.

Signed-off-by: default avatarBrett Creeley <brett.creeley@amd.com>
Signed-off-by: default avatarShannon Nelson <shannon.nelson@amd.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: default avatarRahul Rameshbabu <rrameshbabu@nvidia.com>
Link: https://lore.kernel.org/r/20231204210936.16587-4-shannon.nelson@amd.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 46ca79d2

drivers/net/ethernet/pensando/ionic/ionic_lif.c

+4 −8
Original line number Diff line number Diff line
@@ -424,15 +424,11 @@ static void ionic_qcq_free(struct ionic_lif *lif, struct ionic_qcq *qcq) 


	ionic_qcq_intr_free(lif, qcq);



	if (qcq->cq.info) {

	vfree(qcq->cq.info);

	qcq->cq.info = NULL;

	}

	if (qcq->q.info) {

	vfree(qcq->q.info);

	qcq->q.info = NULL;

}

}



void ionic_qcqs_free(struct ionic_lif *lif)

{