Commit 2d698e8b authored Oct 05, 2023 by Sudeep Holla

firmware: arm_ffa: Allow the FF-A drivers to use 32bit mode of messaging

An FF-A ABI could support both the SMC32 and SMC64 conventions.
A callee that runs in the AArch64 execution state and implements such
an ABI must implement both SMC32 and SMC64 conventions of the ABI.

So the FF-A drivers will need the option to choose the mode irrespective
of FF-A version and the partition execution mode flag in the partition
information.

Let us remove the check on the FF-A version for allowing the selection
of 32bit mode of messaging. The driver will continue to set the 32-bit
mode if the partition execution mode flag specified that the partition
supports only 32-bit execution.

Fixes: 106b11b1 ("firmware: arm_ffa: Set up 32bit execution mode flag using partiion property")
Link: https://lore.kernel.org/r/20231005142823.278121-1-sudeep.holla@arm.com

Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

parent 7d0bc636

drivers/firmware/arm_ffa/driver.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -587,17 +587,9 @@ static int ffa_partition_info_get(const char *uuid_str,
		return 0;
		}

		static void _ffa_mode_32bit_set(struct ffa_device *dev)
		{
		dev->mode_32bit = true;
		}

		static void ffa_mode_32bit_set(struct ffa_device *dev)
		{
		if (drv_info->version > FFA_VERSION_1_0)
		return;

		_ffa_mode_32bit_set(dev);
		dev->mode_32bit = true;
		}

		static int ffa_sync_send_receive(struct ffa_device *dev,
		@@ -706,7 +698,7 @@ static void ffa_setup_partitions(void)

		if (drv_info->version > FFA_VERSION_1_0 &&
		!(tpbuf->properties & FFA_PARTITION_AARCH64_EXEC))
		_ffa_mode_32bit_set(ffa_dev);
		ffa_mode_32bit_set(ffa_dev);
		}
		kfree(pbuf);
		}