Commit 2e4b02fa authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: elx: libefc: Fix potential use after free in efc_nport_vport_del() 



The kref_put() function will call nport->release if the refcount drops to
zero.  The nport->release release function is _efc_nport_free() which frees
"nport".  But then we dereference "nport" on the next line which is a use
after free.  Re-order these lines to avoid the use after free.

Fixes: fcd42730 ("scsi: elx: libefc: SLI and FC PORT state machine interfaces")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/b666ab26-6581-4213-9a3d-32a9147f0399@stanley.mountain


Reviewed-by: default avatarDaniel Wagner <dwagner@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 89835a58

drivers/scsi/elx/libefc/efc_nport.c

+1 −1
Original line number Diff line number Diff line
@@ -705,9 +705,9 @@ efc_nport_vport_del(struct efc *efc, struct efc_domain *domain, 
	spin_lock_irqsave(&efc->lock, flags);

	list_for_each_entry(nport, &domain->nport_list, list_entry) {

		if (nport->wwpn == wwpn && nport->wwnn == wwnn) {

			kref_put(&nport->ref, nport->release);

			/* Shutdown this NPORT */

			efc_sm_post_event(&nport->sm, EFC_EVT_SHUTDOWN, NULL);

			kref_put(&nport->ref, nport->release);

			break;

		}

	}