Commit 2e5e1a7e authored Dec 10, 2024 by Johan Hovold Committed by Bjorn Andersson Dec 19, 2024

Revert "arm64: dts: qcom: x1e80100-crd: enable otg on usb ports"



This reverts commit 2dd32501.

A recent change enabling OTG mode on the x1e81000 CRD breaks suspend.
Specifically, the device hard resets during resume if suspended with all
controllers in device mode (i.e. no USB device connected).

The corresponding change on the T14s also led to SuperSpeed hotplugs not
being detected.

With retimer (and orientation detection) support not even merged yet,
let's revert at least until we have stable host mode in mainline.

Fixes: 2dd32501 ("arm64: dts: qcom: x1e80100-crd: enable otg on usb ports")
Reported-by: Abel Vesa <abel.vesa@linaro.org>
Cc: Jonathan Marek <jonathan@marek.ca>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20241210111444.26240-3-johan+linaro@kernel.org


Signed-off-by: Bjorn Andersson <andersson@kernel.org>

parent fb8e7b33

arch/arm64/boot/dts/qcom/x1e80100-crd.dts

+12 −0

Original line number	Diff line number	Diff line
		@@ -1197,6 +1197,10 @@ &usb_1_ss0 {
		status = "okay";
		};

		&usb_1_ss0_dwc3 {
		dr_mode = "host";
		};

		&usb_1_ss0_dwc3_hs {
		remote-endpoint = <&pmic_glink_ss0_hs_in>;
		};
		@@ -1225,6 +1229,10 @@ &usb_1_ss1 {
		status = "okay";
		};

		&usb_1_ss1_dwc3 {
		dr_mode = "host";
		};

		&usb_1_ss1_dwc3_hs {
		remote-endpoint = <&pmic_glink_ss1_hs_in>;
		};
		@@ -1253,6 +1261,10 @@ &usb_1_ss2 {
		status = "okay";
		};

		&usb_1_ss2_dwc3 {
		dr_mode = "host";
		};

		&usb_1_ss2_dwc3_hs {
		remote-endpoint = <&pmic_glink_ss2_hs_in>;
		};