Commit 2e666595 authored by Rakuram Eswaran's avatar Rakuram Eswaran Committed by Joerg Roedel
Browse files

iommu/amd: Drop incorrect NULL check for iommu in alloc_irq_table() 



alloc_irq_table() contains a conditional check for a NULL iommu pointer
when computing the NUMA node, but the function dereferences iommu
in multiple places afterwards.

All callers ensure that a valid iommu pointer is passed in, and a NULL
iommu is not expected by the current callers. Remove the incorrect
NULL check to make the assumptions consistent and address the Smatch
warning.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202512191724.meqJENXe-lkp@intel.com/


Signed-off-by: default avatarRakuram Eswaran <rakuram.e96@gmail.com>
Reviewed-by: default avatarAnkit Soni <Ankit.Soni@amd.com>
Signed-off-by: default avatarJoerg Roedel <joerg.roedel@amd.com>
parent d2a0cac1

drivers/iommu/amd/iommu.c

+1 −1
Original line number Diff line number Diff line
@@ -3249,7 +3249,7 @@ static struct irq_remap_table *alloc_irq_table(struct amd_iommu *iommu, 
	struct irq_remap_table *new_table = NULL;

	struct amd_iommu_pci_seg *pci_seg;

	unsigned long flags;

	int nid = iommu && iommu->dev ? dev_to_node(&iommu->dev->dev) : NUMA_NO_NODE;

	int nid = iommu->dev ? dev_to_node(&iommu->dev->dev) : NUMA_NO_NODE;

	u16 alias;



	spin_lock_irqsave(&iommu_table_lock, flags);