Unverified Commit 2ed2699f authored by Fabrizio Castro's avatar Fabrizio Castro Committed by Mark Brown
Browse files

spi: rzv2m-csi: Leave readl_poll_timeout calls for last 



Both rzv2m_csi_sw_reset and rzv2m_csi_start_stop_operation
call into readl_poll_timeout upon a certain condition, and
return 0 otherwise.
Flip the logic to improve readability.

Signed-off-by: default avatarFabrizio Castro <fabrizio.castro.jz@renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20230715010407.1751715-5-fabrizio.castro.jz@renesas.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent aecf9fbd

drivers/spi/spi-rzv2m-csi.c

+10 −11
Original line number Diff line number Diff line
@@ -131,15 +131,14 @@ static int rzv2m_csi_sw_reset(struct rzv2m_csi_priv *csi, int assert) 


	rzv2m_csi_reg_write_bit(csi, CSI_CNT, CSI_CNT_CSIRST, assert);



	if (assert) {

	if (!assert)

		return 0;



	return readl_poll_timeout(csi->base + CSI_MODE, reg,

				  !(reg & CSI_MODE_CSOT), 0,

				  CSI_EN_DIS_TIMEOUT_US);

}



	return 0;

}



static int rzv2m_csi_start_stop_operation(const struct rzv2m_csi_priv *csi,

					  int enable, bool wait)

{
@@ -147,12 +146,12 @@ static int rzv2m_csi_start_stop_operation(const struct rzv2m_csi_priv *csi, 


	rzv2m_csi_reg_write_bit(csi, CSI_MODE, CSI_MODE_CSIE, enable);



	if (!enable && wait)

	if (enable || !wait)

		return 0;



	return readl_poll_timeout(csi->base + CSI_MODE, reg,

				  !(reg & CSI_MODE_CSOT), 0,

				  CSI_EN_DIS_TIMEOUT_US);



	return 0;

}



static int rzv2m_csi_fill_txfifo(struct rzv2m_csi_priv *csi)