Commit 2f8d4898 authored by George Guo's avatar George Guo Committed by Tejun Heo
Browse files

sched_ext: Add error logging for dsq creation failures 



Add scx_bpf_error() calls when scx_bpf_create_dsq() fails in multiple
schedulers to improve debuggability:

- scx_central.bpf.c: central_init()
- scx_flatcg.bpf.c: fcg_cgroup_init() and fcg_init()
- scx_qmap.bpf.c: qmap_init()

Signed-off-by: default avatarGeorge Guo <guodongtai@kylinos.cn>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 714d8142

tools/sched_ext/scx_central.bpf.c

+3 −1
Original line number Diff line number Diff line
@@ -301,8 +301,10 @@ int BPF_STRUCT_OPS_SLEEPABLE(central_init) 
	int ret;



	ret = scx_bpf_create_dsq(FALLBACK_DSQ_ID, -1);

	if (ret)

	if (ret) {

		scx_bpf_error("scx_bpf_create_dsq failed (%d)", ret);

		return ret;

	}



	timer = bpf_map_lookup_elem(&central_timer, &key);

	if (!timer)

tools/sched_ext/scx_flatcg.bpf.c

+3 −1
Original line number Diff line number Diff line
@@ -842,8 +842,10 @@ int BPF_STRUCT_OPS_SLEEPABLE(fcg_cgroup_init, struct cgroup *cgrp, 
	 * unlikely case that it breaks.

	 */

	ret = scx_bpf_create_dsq(cgid, -1);

	if (ret)

	if (ret) {

		scx_bpf_error("scx_bpf_create_dsq failed (%d)", ret);

		return ret;

	}



	cgc = bpf_cgrp_storage_get(&cgrp_ctx, cgrp, 0,

				   BPF_LOCAL_STORAGE_GET_F_CREATE);

tools/sched_ext/scx_qmap.bpf.c

+6 −2
Original line number Diff line number Diff line
@@ -866,12 +866,16 @@ s32 BPF_STRUCT_OPS_SLEEPABLE(qmap_init) 
		print_cpus();



	ret = scx_bpf_create_dsq(SHARED_DSQ, -1);

	if (ret)

	if (ret) {

		scx_bpf_error("failed to create DSQ %d (%d)", SHARED_DSQ, ret);

		return ret;

	}



	ret = scx_bpf_create_dsq(HIGHPRI_DSQ, -1);

	if (ret)

	if (ret) {

		scx_bpf_error("failed to create DSQ %d (%d)", HIGHPRI_DSQ, ret);

		return ret;

	}



	timer = bpf_map_lookup_elem(&monitor_timer, &key);

	if (!timer)