Commit 2fcd3ab3 authored by Guixin Liu's avatar Guixin Liu Committed by Keith Busch
Browse files

nvme-fabrics: check ioccsz and iorcsz 



Make sure that ioccsz and iorcsz returned by target are correct before use it.

Per 2.0a base NVMe spec:

  I/O Queue Command Capsule Supported Size (IOCCSZ): This field defines
  the maximum I/O command capsule size in 16 byte units. The minimum value
  that shall be indicated is 4 corresponding to 64 bytes.

Signed-off-by: default avatarGuixin Liu <kanie@linux.alibaba.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 68999d1d

drivers/nvme/host/core.c

+14 −0
Original line number Diff line number Diff line
@@ -3022,6 +3022,20 @@ static int nvme_check_ctrl_fabric_info(struct nvme_ctrl *ctrl, struct nvme_id_ct 
		return -EINVAL;

	}



	if (ctrl->ioccsz < 4) {

		dev_err(ctrl->device,

			"I/O queue command capsule supported size %d < 4\n",

			ctrl->ioccsz);

		return -EINVAL;

	}



	if (ctrl->iorcsz < 1) {

		dev_err(ctrl->device,

			"I/O queue response capsule supported size %d < 1\n",

			ctrl->iorcsz);

		return -EINVAL;

	}



	return 0;

}