Commit 302c0411 authored Sep 20, 2025 by Ma Ke Committed by Andreas Larsson Sep 22, 2025

sparc: fix error handling in scan_one_device()



Once of_device_register() failed, we should call put_device() to
decrement reference count for cleanup. Or it could cause memory leak.
So fix this by calling put_device(), then the name can be freed in
kobject_cleanup().

Calling path: of_device_register() -> of_device_add() -> device_add().
As comment of device_add() says, 'if device_add() succeeds, you should
call device_del() when you want to get rid of it. If device_add() has
not succeeded, use only put_device() to drop the reference count'.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: cf44bbc2 ("[SPARC]: Beginnings of generic of_device framework.")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Andreas Larsson <andreas@gaisler.com>
Signed-off-by: Andreas Larsson <andreas@gaisler.com>

parent 936fb512

arch/sparc/kernel/of_device_32.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -387,6 +387,7 @@ static struct platform_device * __init scan_one_device(struct device_node *dp,

		if (of_device_register(op)) {
		printk("%pOF: Could not register of device.\n", dp);
		put_device(&op->dev);
		kfree(op);
		op = NULL;
		}

arch/sparc/kernel/of_device_64.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -677,6 +677,7 @@ static struct platform_device * __init scan_one_device(struct device_node *dp,

		if (of_device_register(op)) {
		printk("%pOF: Could not register of device.\n", dp);
		put_device(&op->dev);
		kfree(op);
		op = NULL;
		}