Commit 31bedc1f authored by Luo Yifan's avatar Luo Yifan Committed by Arnaldo Carvalho de Melo
Browse files

libsubcmd: Move va_end() before exit 



This patch makes a minor adjustment by moving the va_end call before
exit. Since the exit() function terminates the program, any code
after exit(128) (i.e., va_end(params)) is unreachable and thus not
executed. Placing va_end before exit ensures that the va_list is
properly cleaned up.

Signed-off-by: default avatarLuo Yifan <luoyifan@cmss.chinamobile.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lore.kernel.org/r/20241111091701.275496-1-luoyifan@cmss.chinamobile.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent b81bb703

tools/lib/subcmd/subcmd-util.h

+1 −1
Original line number Diff line number Diff line
@@ -20,8 +20,8 @@ static __noreturn inline void die(const char *err, ...) 


	va_start(params, err);

	report(" Fatal: ", err, params);

	exit(128);

	va_end(params);

	exit(128);

}



#define zfree(ptr) ({ free(*ptr); *ptr = NULL; })