Commit 32291cb0 authored by Alok Tiwari's avatar Alok Tiwari Committed by Jakub Kicinski
Browse files

net: marvell: prestera: correct return type of prestera_ldr_wait_buf() 



prestera_ldr_wait_buf() returns the result of readl_poll_timeout(),
which is 0 on success or -ETIMEDOUT on failure. Its current return
type is u32.

Assigning this u32 value to an int variable works today because the
bit pattern of (u32)-ETIMEDOUT (0xffffff92) is correctly interpreted
as -ETIMEDOUT when stored in an int. However, keeping the function
return type as u32 is misleading and fragile.

Change the return type to int to reflect the actual semantic of
returning negative error codes and to avoid potential issues with
unsigned casts. There is no functional change.

Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260103174313.1172197-1-alok.a.tiwari@oracle.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2e229771

drivers/net/ethernet/marvell/prestera/prestera_pci.c

+1 −1
Original line number Diff line number Diff line
@@ -542,7 +542,7 @@ static int prestera_ldr_wait_reg32(struct prestera_fw *fw, 
				  10 * USEC_PER_MSEC, waitms * USEC_PER_MSEC);

}



static u32 prestera_ldr_wait_buf(struct prestera_fw *fw, size_t len)

static int prestera_ldr_wait_buf(struct prestera_fw *fw, size_t len)

{

	u8 __iomem *addr = PRESTERA_LDR_REG_ADDR(fw, PRESTERA_LDR_BUF_RD_REG);

	u32 buf_len = fw->ldr_buf_len;