Commit 32a8d362 authored by Wolfram Sang's avatar Wolfram Sang Committed by Alexandre Belloni
Browse files

hwmon: (spd5118) Use generic parity calculation 



Make use of the new generic helper for calculating the parity.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarGuenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarKuan-Wei Chiu <visitorckw@gmail.com>
Link: https://lore.kernel.org/r/20250107090204.6593-3-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent c320592f

drivers/hwmon/spd5118.c

+1 −7
Original line number Diff line number Diff line
@@ -291,12 +291,6 @@ static umode_t spd5118_is_visible(const void *_data, enum hwmon_sensor_types typ 
	}

}



static inline bool spd5118_parity8(u8 w)

{

	w ^= w >> 4;

	return (0x6996 >> (w & 0xf)) & 1;

}



/*

 * Bank and vendor id are 8-bit fields with seven data bits and odd parity.

 * Vendor IDs 0 and 0x7f are invalid.
@@ -304,7 +298,7 @@ static inline bool spd5118_parity8(u8 w) 
 */

static bool spd5118_vendor_valid(u8 bank, u8 id)

{

	if (!spd5118_parity8(bank) || !spd5118_parity8(id))

	if (parity8(bank) == 0 || parity8(id) == 0)

		return false;



	id &= 0x7f;