Commit 32b0901e authored by Yuan Can's avatar Yuan Can Committed by Tzung-Bi Shih
Browse files

firmware: google: Unregister driver_info on failure 



When platform_device_register_full() returns error, the gsmi_init() returns
without unregister gsmi_driver_info, fix by add missing
platform_driver_unregister() when platform_device_register_full() failed.

Fixes: 8942b2d5 ("gsmi: Add GSMI commands to log S0ix info")
Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
Acked-by: default avatarBrian Norris <briannorris@chromium.org>
Link: https://lore.kernel.org/r/20241015131344.20272-1-yuancan@huawei.com


Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent 67f488df

drivers/firmware/google/gsmi.c

+4 −2
Original line number Diff line number Diff line
@@ -918,7 +918,8 @@ static __init int gsmi_init(void) 
	gsmi_dev.pdev = platform_device_register_full(&gsmi_dev_info);

	if (IS_ERR(gsmi_dev.pdev)) {

		printk(KERN_ERR "gsmi: unable to register platform device\n");

		return PTR_ERR(gsmi_dev.pdev);

		ret = PTR_ERR(gsmi_dev.pdev);

		goto out_unregister;

	}



	/* SMI access needs to be serialized */
@@ -1056,10 +1057,11 @@ static __init int gsmi_init(void) 
	gsmi_buf_free(gsmi_dev.name_buf);

	kmem_cache_destroy(gsmi_dev.mem_pool);

	platform_device_unregister(gsmi_dev.pdev);

	pr_info("gsmi: failed to load: %d\n", ret);

out_unregister:

#ifdef CONFIG_PM

	platform_driver_unregister(&gsmi_driver_info);

#endif

	pr_info("gsmi: failed to load: %d\n", ret);

	return ret;

}