Commit 3396995f authored by Haoyu Li's avatar Haoyu Li Committed by Bartosz Golaszewski
Browse files

gpio: ljca: Initialize num before accessing item in ljca_gpio_config 



With the new __counted_by annocation in ljca_gpio_packet, the "num"
struct member must be set before accessing the "item" array. Failing to
do so will trigger a runtime warning when enabling CONFIG_UBSAN_BOUNDS
and CONFIG_FORTIFY_SOURCE.

Fixes: 1034cc42 ("gpio: update Intel LJCA USB GPIO driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarHaoyu Li <lihaoyu499@gmail.com>
Link: https://lore.kernel.org/stable/20241203141451.342316-1-lihaoyu499%40gmail.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 70327137

drivers/gpio/gpio-ljca.c

+1 −1
Original line number Diff line number Diff line
@@ -82,9 +82,9 @@ static int ljca_gpio_config(struct ljca_gpio_dev *ljca_gpio, u8 gpio_id, 
	int ret;



	mutex_lock(&ljca_gpio->trans_lock);

	packet->num = 1;

	packet->item[0].index = gpio_id;

	packet->item[0].value = config | ljca_gpio->connect_mode[gpio_id];

	packet->num = 1;



	ret = ljca_transfer(ljca_gpio->ljca, LJCA_GPIO_CONFIG, (u8 *)packet,

			    struct_size(packet, item, packet->num), NULL, 0);