Commit 35025963 authored by Si-Wei Liu's avatar Si-Wei Liu Committed by Michael S. Tsirkin
Browse files

vdpa/mlx5: Fix suboptimal range on iotlb iteration 



The starting iova address to iterate iotlb map entry within a range
was set to an irrelevant value when passing to the itree_next()
iterator, although luckily it doesn't affect the outcome of finding
out the granule of the smallest iotlb map size. Fix the code to make
it consistent with the following for-loop.

Fixes: 94abbccd ("vdpa/mlx5: Add shared memory registration code")
Signed-off-by: default avatarSi-Wei Liu <si-wei.liu@oracle.com>
Signed-off-by: default avatarDragos Tatulea <dtatulea@nvidia.com>
Message-Id: <20241021134040.975221-3-dtatulea@nvidia.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
parent 29ce8b8a

drivers/vdpa/mlx5/core/mr.c

+1 −3
Original line number Diff line number Diff line
@@ -368,7 +368,6 @@ static int map_direct_mr(struct mlx5_vdpa_dev *mvdev, struct mlx5_vdpa_direct_mr 
	unsigned long lgcd = 0;

	int log_entity_size;

	unsigned long size;

	u64 start = 0;

	int err;

	struct page *pg;

	unsigned int nsg;
@@ -379,10 +378,9 @@ static int map_direct_mr(struct mlx5_vdpa_dev *mvdev, struct mlx5_vdpa_direct_mr 
	struct device *dma = mvdev->vdev.dma_dev;



	for (map = vhost_iotlb_itree_first(iotlb, mr->start, mr->end - 1);

	     map; map = vhost_iotlb_itree_next(map, start, mr->end - 1)) {

	     map; map = vhost_iotlb_itree_next(map, mr->start, mr->end - 1)) {

		size = maplen(map, mr);

		lgcd = gcd(lgcd, size);

		start += size;

	}

	log_entity_size = ilog2(lgcd);