Commit 35337175 authored by Xiao Liang's avatar Xiao Liang Committed by Jakub Kicinski
Browse files

ieee802154: 6lowpan: Validate link netns in newlink() of rtnl_link_ops 



Device denoted by IFLA_LINK is in link_net (IFLA_LINK_NETNSID) or
source netns by design, but 6lowpan uses dev_net.

Note dev->netns_local is set to true and currently link_net is
implemented via a netns change. These together effectively reject
IFLA_LINK_NETNSID.

This patch adds a validation to ensure link_net is either NULL or
identical to dev_net. Thus it would be fine to continue using dev_net
when rtnetlink core begins to create devices directly in target netns.

Signed-off-by: default avatarXiao Liang <shaw.leon@gmail.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250219125039.18024-5-shaw.leon@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent cf517ac1

net/ieee802154/6lowpan/core.c

+2 −0
Original line number Diff line number Diff line
@@ -143,6 +143,8 @@ static int lowpan_newlink(struct net_device *ldev, 


	if (!tb[IFLA_LINK])

		return -EINVAL;

	if (params->link_net && !net_eq(params->link_net, dev_net(ldev)))

		return -EINVAL;

	/* find and hold wpan device */

	wdev = dev_get_by_index(dev_net(ldev), nla_get_u32(tb[IFLA_LINK]));

	if (!wdev)