Commit 35597bdb authored by Adrian Hunter's avatar Adrian Hunter Committed by Ulf Hansson
Browse files

mmc: cqhci: Warn of halt or task clear failure 



A correctly operating controller should successfully halt and clear tasks.
Failure may result in errors elsewhere, so promote messages from debug to
warnings.

Fixes: a4080225 ("mmc: cqhci: support for command queue enabled host")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Reviewed-by: default avatarAvri Altman <avri.altman@wdc.com>
Reviewed-by: default avatarAvri Altman <avri.altman@wdc.com>
Link: https://lore.kernel.org/r/20231103084720.6886-6-adrian.hunter@intel.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 8155d1fa

drivers/mmc/host/cqhci-core.c

+3 −3
Original line number Diff line number Diff line
@@ -942,7 +942,7 @@ static bool cqhci_clear_all_tasks(struct mmc_host *mmc, unsigned int timeout) 
	ret = cqhci_tasks_cleared(cq_host);



	if (!ret)

		pr_debug("%s: cqhci: Failed to clear tasks\n",

		pr_warn("%s: cqhci: Failed to clear tasks\n",

			mmc_hostname(mmc));



	return ret;
@@ -976,7 +976,7 @@ static bool cqhci_halt(struct mmc_host *mmc, unsigned int timeout) 
	ret = cqhci_halted(cq_host);



	if (!ret)

		pr_debug("%s: cqhci: Failed to halt\n", mmc_hostname(mmc));

		pr_warn("%s: cqhci: Failed to halt\n", mmc_hostname(mmc));



	return ret;

}