Commit 356d2c8e authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Sam Ravnborg
Browse files

drm/client: Use actual bpp when allocating frame buffers 



When allocating a frame buffer, the number of bits per pixel needed is
derived from the deprecated drm_format_info.cpp[] field.  While this may
work for formats using less than 8 bits per pixel, it does lead to a
large overallocation.

Reduce memory consumption by using the actual number of bits per pixel
instead.

Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Acked-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/eabcf4f298184dabe46823fcf5ceffa1da0ec7ef.1657294931.git.geert@linux-m68k.org
parent dc1dc76b

drivers/gpu/drm/drm_client.c

+2 −2
Original line number Diff line number Diff line
@@ -264,7 +264,7 @@ drm_client_buffer_create(struct drm_client_dev *client, u32 width, u32 height, u 


	dumb_args.width = width;

	dumb_args.height = height;

	dumb_args.bpp = info->cpp[0] * 8;

	dumb_args.bpp = drm_format_info_bpp(info, 0);

	ret = drm_mode_create_dumb(dev, &dumb_args, client->file);

	if (ret)

		goto err_delete;
@@ -373,7 +373,7 @@ static int drm_client_buffer_addfb(struct drm_client_buffer *buffer, 
	int ret;



	info = drm_format_info(format);

	fb_req.bpp = info->cpp[0] * 8;

	fb_req.bpp = drm_format_info_bpp(info, 0);

	fb_req.depth = info->depth;

	fb_req.width = width;

	fb_req.height = height;