Commit 35c3730a authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: Call scsi_done() directly 

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007204618.2196847-1-bvanassche@acm.org


Reviewed-by: default avatarBean Huo <beanhuo@micron.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 37425f5d

drivers/scsi/ufs/ufshcd.c

+3 −3
Original line number Diff line number Diff line
@@ -2714,7 +2714,7 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) 
		if (hba->pm_op_in_progress) {

			hba->force_reset = true;

			set_host_byte(cmd, DID_BAD_TARGET);

			cmd->scsi_done(cmd);

			scsi_done(cmd);

			goto out;

		}

		fallthrough;
@@ -2723,7 +2723,7 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) 
		goto out;

	case UFSHCD_STATE_ERROR:

		set_host_byte(cmd, DID_ERROR);

		cmd->scsi_done(cmd);

		scsi_done(cmd);

		goto out;

	}
@@ -5275,7 +5275,7 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba, 
			/* Mark completed command as NULL in LRB */

			lrbp->cmd = NULL;

			/* Do not touch lrbp after scsi done */

			cmd->scsi_done(cmd);

			scsi_done(cmd);

			ufshcd_release(hba);

			update_scaling = true;

		} else if (lrbp->command_type == UTP_CMD_TYPE_DEV_MANAGE ||