Commit 35fe2ad2 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Guenter Roeck
Browse files

hwmon: (nzxt-kraken2) Fix error handling path in kraken2_probe() 



There is no point in calling hid_hw_stop() if hid_hw_start() has failed.
There is no point in calling hid_hw_close() if hid_hw_open() has failed.

Update the error handling path accordingly.

Fixes: 82e3430d ("hwmon: add driver for NZXT Kraken X42/X52/X62/X72")
Reported-by: default avatarAleksa Savic <savicaleksa83@gmail.com>
Closes: https://lore.kernel.org/all/121470f0-6c1f-418a-844c-7ec2e8a54b8e@gmail.com/


Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarJonas Malaco <jonas@protocubo.io>
Link: https://lore.kernel.org/r/a768e69851a07a1f4e29f270f4e2559063f07343.1701617030.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 1fefca6c

drivers/hwmon/nzxt-kraken2.c

+2 −2
Original line number Diff line number Diff line
@@ -161,13 +161,13 @@ static int kraken2_probe(struct hid_device *hdev, 
	ret = hid_hw_start(hdev, HID_CONNECT_HIDRAW);

	if (ret) {

		hid_err(hdev, "hid hw start failed with %d\n", ret);

		goto fail_and_stop;

		return ret;

	}



	ret = hid_hw_open(hdev);

	if (ret) {

		hid_err(hdev, "hid hw open failed with %d\n", ret);

		goto fail_and_close;

		goto fail_and_stop;

	}



	priv->hwmon_dev = hwmon_device_register_with_info(&hdev->dev, "kraken2",