Commit 361fa7f8 authored by Thorsten Blum's avatar Thorsten Blum Committed by Herbert Xu
Browse files

crypto: octeontx2 - Call strscpy() with correct size argument 



In otx2_cpt_dl_custom_egrp_create(), strscpy() is called with the length
of the source string rather than the size of the destination buffer.

This is fine as long as the destination buffer is larger than the source
string, but we should still use the destination buffer size instead to
call strscpy() as intended. And since 'tmp_buf' is a fixed-size buffer,
we can safely omit the size argument and let strscpy() infer it using
sizeof().

Fixes: d9d77497 ("crypto: octeontx2 - add apis for custom engine groups")
Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 11d5674f

drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c

+1 −1
Original line number Diff line number Diff line
@@ -1615,7 +1615,7 @@ int otx2_cpt_dl_custom_egrp_create(struct otx2_cptpf_dev *cptpf, 
		return -EINVAL;

	}

	err_msg = "Invalid engine group format";

	strscpy(tmp_buf, ctx->val.vstr, strlen(ctx->val.vstr) + 1);

	strscpy(tmp_buf, ctx->val.vstr);

	start = tmp_buf;



	has_se = has_ie = has_ae = false;