Commit 366f05e3 authored by Unnathi Chalicheemala's avatar Unnathi Chalicheemala Committed by Bjorn Andersson
Browse files

firmware: qcom_scm: Use TASK_IDLE state in wait_for_wq_completion() 



When the kernel issues an SMC (Secure Monitor Call) and the firmware
requests the kernel to wait, the waiting thread enters an
uninterruptible (D) state. In case of an extended wait request by the
firmware, any device suspend request, cannot proceed because of the
thread stuck in D state. This blocks the device suspend.

Replace wait_for_completion() with wait_for_completion_state(...,
TASK_IDLE), so that the waiting thread, show up in TASK_IDLE state,
instead of TASK_UNINTERRUPTIBLE (D state). This allows the thread to
block until completion, without blocking the device suspend.

Reviewed-by: default avatarMukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Reviewed-by: default avatarBartosz Golaszewski <brgl@kernel.org>
Signed-off-by: default avatarUnnathi Chalicheemala <unnathi.chalicheemala@oss.qualcomm.com>
Signed-off-by: default avatarShivendra Pratap <shivendra.pratap@oss.qualcomm.com>
Reviewed-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/r/20251217-multi_waitq_scm-v11-3-f21e50e792b8@oss.qualcomm.com


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent ccd207ec

drivers/firmware/qcom/qcom_scm.c

+1 −1
Original line number Diff line number Diff line
@@ -2306,7 +2306,7 @@ int qcom_scm_wait_for_wq_completion(u32 wq_ctx) 
	if (IS_ERR(wq))

		return PTR_ERR(wq);



	wait_for_completion(wq);

	wait_for_completion_state(wq, TASK_IDLE);



	return 0;

}