Commit 38762580 authored by Jeff Layton's avatar Jeff Layton Committed by Chuck Lever
Browse files

nfsd: remove obsolete comment from nfs4_alloc_stid 



idr_alloc_cyclic() is what guarantees that now, not this long-gone trick.

Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent d917d783

fs/nfsd/nfs4state.c

+0 −9
Original line number Diff line number Diff line
@@ -946,15 +946,6 @@ struct nfs4_stid *nfs4_alloc_stid(struct nfs4_client *cl, struct kmem_cache *sla 
	spin_lock_init(&stid->sc_lock);

	INIT_LIST_HEAD(&stid->sc_cp_list);



	/*

	 * It shouldn't be a problem to reuse an opaque stateid value.

	 * I don't think it is for 4.1.  But with 4.0 I worry that, for

	 * example, a stray write retransmission could be accepted by

	 * the server when it should have been rejected.  Therefore,

	 * adopt a trick from the sctp code to attempt to maximize the

	 * amount of time until an id is reused, by ensuring they always

	 * "increase" (mod INT_MAX):

	 */

	return stid;

out_free:

	kmem_cache_free(slab, stid);