Commit 387b5170 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpufreq: Consolidate some code in cpufreq_online() 



Notice that the policy->cpu update in cpufreq_policy_alloc() can be
moved to cpufreq_online() and then it can be carried out under the
policy rwsem, along with the clearing of policy->governor (unnecessary
in the "new policy" code branch, but also not harmful).  If this is
done, the bottom parts of the "if (policy)" branches become identical
and they can be collapsed and moved below the conditional.

Modify the code accordingly which makes it somewhat easier to follow.

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Acked-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Tested-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Link: https://patch.msgid.link/13741234.uLZWGnKmhe@rjwysocki.net
parent 0af2f6be

drivers/cpufreq/cpufreq.c

+5 −5
Original line number Diff line number Diff line
@@ -1334,7 +1334,6 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) 
	init_waitqueue_head(&policy->transition_wait);

	INIT_WORK(&policy->update, handle_update);



	policy->cpu = cpu;

	return policy;



err_min_qos_notifier:
@@ -1422,17 +1421,18 @@ static int cpufreq_online(unsigned int cpu) 


		/* This is the only online CPU for the policy.  Start over. */

		new_policy = false;

		down_write(&policy->rwsem);

		policy->cpu = cpu;

		policy->governor = NULL;

	} else {

		new_policy = true;

		policy = cpufreq_policy_alloc(cpu);

		if (!policy)

			return -ENOMEM;

		down_write(&policy->rwsem);

	}



	down_write(&policy->rwsem);



	policy->cpu = cpu;

	policy->governor = NULL;



	if (!new_policy && cpufreq_driver->online) {

		/* Recover policy->cpus using related_cpus */

		cpumask_copy(policy->cpus, policy->related_cpus);