Commit 38935f33 authored by Wolfram Sang's avatar Wolfram Sang Committed by Greg Kroah-Hartman
Browse files

usb: typec: tcpm: use 'time_left' variable with wait_for_completion_timeout() 



There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

	timeout = wait_for_completion_timeout(...)
	if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240604212730.4968-2-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 58be297b

drivers/usb/typec/tcpm/tcpm.c

+4 −4
Original line number Diff line number Diff line
@@ -944,7 +944,7 @@ static int tcpm_pd_transmit(struct tcpm_port *port, 
			    enum tcpm_transmit_type tx_sop_type,

			    const struct pd_message *msg)

{

	unsigned long timeout;

	unsigned long time_left;

	int ret;

	unsigned int negotiated_rev;
@@ -969,10 +969,10 @@ static int tcpm_pd_transmit(struct tcpm_port *port, 
		return ret;



	mutex_unlock(&port->lock);

	timeout = wait_for_completion_timeout(&port->tx_complete,

	time_left = wait_for_completion_timeout(&port->tx_complete,

						msecs_to_jiffies(PD_T_TCPC_TX_TIMEOUT));

	mutex_lock(&port->lock);

	if (!timeout)

	if (!time_left)

		return -ETIMEDOUT;



	switch (port->tx_status) {