Commit 39c3aad4 authored Sep 22, 2024 by Ahmed Ehab Committed by Kent Overstreet Sep 21, 2024

bcachefs: Hold read lock in bch2_snapshot_tree_oldest_subvol()



Syzbot reports a problem that a warning is triggered due to suspicious
use of rcu_dereference_check(). That is triggered by a call of
bch2_snapshot_tree_oldest_subvol().

The cause of the warning is that inside
bch2_snapshot_tree_oldest_subvol(), snapshot_t() is called which calls
rcu_dereference() that requires a read lock to be held. Also, the call
of bch2_snapshot_tree_next() eventually calls snapshot_t().

To fix this, call rcu_read_lock() before calling snapshot_t(). Then,
release the lock after the termination of the while loop.

Reported-by:  <syzbot+f7c41a878676b72c16a6@syzkaller.appspotmail.com>
Signed-off-by: Ahmed Ehab <bottaawesome633@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

parent 025c55a4

fs/bcachefs/snapshot.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -469,6 +469,7 @@ static u32 bch2_snapshot_tree_oldest_subvol(struct bch_fs *c, u32 snapshot_root)
		u32 id = snapshot_root;
		u32 subvol = 0, s;

		rcu_read_lock();
		while (id) {
		s = snapshot_t(c, id)->subvol;

		@@ -477,6 +478,7 @@ static u32 bch2_snapshot_tree_oldest_subvol(struct bch_fs *c, u32 snapshot_root)

		id = bch2_snapshot_tree_next(c, id);
		}
		rcu_read_unlock();

		return subvol;
		}