Commit 39ebd6dc authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Andrew Morton
Browse files

mm/memory-failure: cast index to loff_t before shifting it 

On 32-bit systems, we'll lose the top bits of index because arithmetic
will be performed in unsigned long instead of unsigned long long.  This
affects files over 4GB in size.

Link: https://lkml.kernel.org/r/20231218135837.3310403-4-willy@infradead.org


Fixes: 6100e34b ("mm, memory_failure: Teach memory_failure() about dev_pagemap pages")
Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent c79c5a0a

mm/memory-failure.c

+1 −1
Original line number Diff line number Diff line
@@ -1704,7 +1704,7 @@ static void unmap_and_kill(struct list_head *to_kill, unsigned long pfn, 
		 * mapping being torn down is communicated in siginfo, see

		 * kill_proc()

		 */

		loff_t start = (index << PAGE_SHIFT) & ~(size - 1);

		loff_t start = ((loff_t)index << PAGE_SHIFT) & ~(size - 1);



		unmap_mapping_range(mapping, start, size, 0);

	}