Commit 3a3ef394 authored by Benjamin Berg's avatar Benjamin Berg Committed by Johannes Berg
Browse files

wifi: iwlwifi: mvm: skip adding debugfs symlink for reconfig 



The function to add an interface may be called without a previous
removal if the HW is being reconfigured. As such, only add the symlink
if the hardware is not being reconfigured due to a HW_RESTART.

Fixes: c36235ac ("wifi: iwlwifi: mvm: rework debugfs handling")
Signed-off-by: default avatarBenjamin Berg <benjamin.berg@intel.com>
Reviewed-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240123200528.314395eacda4.I5823e962c3c3674b942383733debd10b3fe903e2@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent b743287d

drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

+4 −2
Original line number Diff line number Diff line
@@ -1600,6 +1600,7 @@ static int iwl_mvm_mac_add_interface(struct ieee80211_hw *hw, 
	 */

	if (vif->type == NL80211_IFTYPE_AP ||

	    vif->type == NL80211_IFTYPE_ADHOC) {

		if (!test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status))

			iwl_mvm_vif_dbgfs_add_link(mvm, vif);

		ret = 0;

		goto out;
@@ -1640,6 +1641,7 @@ static int iwl_mvm_mac_add_interface(struct ieee80211_hw *hw, 
			iwl_mvm_chandef_get_primary_80(&vif->bss_conf.chandef);

	}



	if (!test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status))

		iwl_mvm_vif_dbgfs_add_link(mvm, vif);



	if (!test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status) &&

drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c

+2 −1
Original line number Diff line number Diff line
@@ -81,6 +81,7 @@ static int iwl_mvm_mld_mac_add_interface(struct ieee80211_hw *hw, 
		ieee80211_hw_set(mvm->hw, RX_INCLUDES_FCS);

	}



	if (!test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status))

		iwl_mvm_vif_dbgfs_add_link(mvm, vif);



	if (!test_bit(IWL_MVM_STATUS_IN_HW_RESTART, &mvm->status) &&