Commit 3b14430c authored by Arkadiusz Kubalewski's avatar Arkadiusz Kubalewski Committed by Tony Nguyen
Browse files

ice: fix dpll input pin phase_adjust value updates 



The value of phase_adjust for input pin shall be updated in
ice_dpll_pin_state_update(..). Fix by adding proper argument to the
firmware query function call - a pin's struct field pointer where the
phase_adjust value during driver runtime is stored.

Previously the phase_adjust used to misinform user about actual
phase_adjust value. I.e., if phase_adjust was set to a non zero value and
if driver was reloaded, the user would see the value equal 0, which is
not correct - the actual value is equal to value set before driver reload.

Fixes: 90e1c907 ("ice: dpll: implement phase related callbacks")
Reviewed-by: default avatarAlan Brady <alan.brady@intel.com>
Signed-off-by: default avatarArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent e8335ef5

drivers/net/ethernet/intel/ice/ice_dpll.c

+1 −1
Original line number Diff line number Diff line
@@ -373,7 +373,7 @@ ice_dpll_pin_state_update(struct ice_pf *pf, struct ice_dpll_pin *pin, 
	case ICE_DPLL_PIN_TYPE_INPUT:

		ret = ice_aq_get_input_pin_cfg(&pf->hw, pin->idx, NULL, NULL,

					       NULL, &pin->flags[0],

					       &pin->freq, NULL);

					       &pin->freq, &pin->phase_adjust);

		if (ret)

			goto err;

		if (ICE_AQC_GET_CGU_IN_CFG_FLG2_INPUT_EN & pin->flags[0]) {