Commit 3b46a9e4 authored by Kalesh AP's avatar Kalesh AP Committed by Paolo Abeni
Browse files

bnxt_en: Drop redundant if block in bnxt_dl_flash_update() 



The devlink stack has sanity checks and it invokes flash_update()
only if it is supported by the driver.  The VF driver does not
advertise the support for flash_update in struct devlink_ops.
This makes if condition inside bnxt_dl_flash_update() redundant.

Reviewed-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250917040839.1924698-2-michael.chan@broadcom.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 64d26169

drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

+0 −6
Original line number Diff line number Diff line
@@ -40,12 +40,6 @@ bnxt_dl_flash_update(struct devlink *dl, 
	struct bnxt *bp = bnxt_get_bp_from_dl(dl);

	int rc;



	if (!BNXT_PF(bp)) {

		NL_SET_ERR_MSG_MOD(extack,

				   "flash update not supported from a VF");

		return -EPERM;

	}



	devlink_flash_update_status_notify(dl, "Preparing to flash", NULL, 0, 0);

	rc = bnxt_flash_package_from_fw_obj(bp->dev, params->fw, 0, extack);

	if (!rc)