Commit 3b5091fe authored by Ranjan Kumar's avatar Ranjan Kumar Committed by Martin K. Petersen
Browse files

scsi: mpi3mr: Reset the pending interrupt flag 



If an admin interrupt is missed, admin_pend_isr may stay set and trigger
admin reply processing even when no admin I/Os are pending.

Clearing/Resetting it in the admin completion path prevents this.

Fixes: ca41929b ("scsi: mpi3mr: Check admin reply queue from Watchdog")
Cc: stable@vger.kernel.org
Co-developed-by: default avatarSathya Prakash <sathya.prakash@broadcom.com>
Signed-off-by: default avatarSathya Prakash <sathya.prakash@broadcom.com>
Signed-off-by: default avatarRanjan Kumar <ranjan.kumar@broadcom.com>
Link: https://lore.kernel.org/r/20250411111419.135485-3-ranjan.kumar@broadcom.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent cdd44525

drivers/scsi/mpi3mr/mpi3mr_fw.c

+3 −0
Original line number Diff line number Diff line
@@ -451,6 +451,7 @@ int mpi3mr_process_admin_reply_q(struct mpi3mr_ioc *mrioc) 
		return 0;

	}



	atomic_set(&mrioc->admin_pend_isr, 0);

	reply_desc = (struct mpi3_default_reply_descriptor *)mrioc->admin_reply_base +

	    admin_reply_ci;
@@ -2925,6 +2926,7 @@ static int mpi3mr_setup_admin_qpair(struct mpi3mr_ioc *mrioc) 
	mrioc->admin_reply_ci = 0;

	mrioc->admin_reply_ephase = 1;

	atomic_set(&mrioc->admin_reply_q_in_use, 0);

	atomic_set(&mrioc->admin_pend_isr, 0);



	if (!mrioc->admin_req_base) {

		mrioc->admin_req_base = dma_alloc_coherent(&mrioc->pdev->dev,
@@ -4653,6 +4655,7 @@ void mpi3mr_memset_buffers(struct mpi3mr_ioc *mrioc) 
	if (mrioc->admin_reply_base)

		memset(mrioc->admin_reply_base, 0, mrioc->admin_reply_q_sz);

	atomic_set(&mrioc->admin_reply_q_in_use, 0);

	atomic_set(&mrioc->admin_pend_isr, 0);



	if (mrioc->init_cmds.reply) {

		memset(mrioc->init_cmds.reply, 0, sizeof(*mrioc->init_cmds.reply));