Commit 3b721117 authored by Ethan Nelson-Moore's avatar Ethan Nelson-Moore Committed by Jakub Kicinski
Browse files

net: usb: sr9700: replace magic numbers with register bit macros 



The first byte of the Rx frame is a copy of the Rx status register, so
0x40 corresponds to RSR_MF (meaning the frame is multicast). Replace
0x40 with RSR_MF for clarity. (All other bits of the RSR indicate
errors. The fact that the driver ignores these errors will be fixed by
a later patch.)

The first byte of the status URB is a copy of the NSR, so 0x40
corresponds to NSR_LINKST. Replace 0x40 with NSR_LINKST for clarity.

Signed-off-by: default avatarEthan Nelson-Moore <enelsonmoore@gmail.com>
Reviewed-by: default avatarPeter Korsgaard <peter@korsgaard.com>
Link: https://patch.msgid.link/20260124032248.26807-1-enelsonmoore@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 90defad2

drivers/net/usb/sr9700.c

+2 −2
Original line number Diff line number Diff line
@@ -366,7 +366,7 @@ static int sr9700_rx_fixup(struct usbnet *dev, struct sk_buff *skb) 


	/* one skb may contains multiple packets */

	while (skb->len > SR_RX_OVERHEAD) {

		if (skb->data[0] != 0x40)

		if (skb->data[0] != RSR_MF)

			return 0;



		/* ignore the CRC length */
@@ -455,7 +455,7 @@ static void sr9700_status(struct usbnet *dev, struct urb *urb) 


	buf = urb->transfer_buffer;



	link = !!(buf[0] & 0x40);

	link = !!(buf[0] & NSR_LINKST);

	sr9700_handle_link_change(dev->net, link);

}