Commit 3c5d61ae authored by Uladzislau Rezki (Sony)'s avatar Uladzislau Rezki (Sony) Committed by Vlastimil Babka
Browse files

rcu/kvfree: Refactor kvfree_rcu_queue_batch() 



Improve readability of kvfree_rcu_queue_batch() function
in away that, after a first batch queuing, the loop is break
and success value is returned to a caller.

There is no reason to loop and check batches further as all
outstanding objects have already been picked and attached to
a certain batch to complete an offloading.

Fixes: 2b55d6a4 ("rcu/kvfree: Add kvfree_rcu_barrier() API")
Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Closes: https://lore.kernel.org/lkml/ZvWUt2oyXRsvJRNc@pc636/T/


Signed-off-by: default avatarUladzislau Rezki (Sony) <urezki@gmail.com>
Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
parent 77ced98f

kernel/rcu/tree.c

+5 −4
Original line number Diff line number Diff line
@@ -3607,11 +3607,12 @@ kvfree_rcu_queue_batch(struct kfree_rcu_cpu *krcp) 
			}



			// One work is per one batch, so there are three

			// "free channels", the batch can handle. It can

			// be that the work is in the pending state when

			// channels have been detached following by each

			// other.

			// "free channels", the batch can handle. Break

			// the loop since it is done with this CPU thus

			// queuing an RCU work is _always_ success here.

			queued = queue_rcu_work(system_unbound_wq, &krwp->rcu_work);

			WARN_ON_ONCE(!queued);

			break;

		}

	}