Commit 3c838184 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Bartosz Golaszewski
Browse files

gpio: altera: Drop .mapped_irq from driver data 



struct altera_gpio_chip::mapped_irq is only used in the driver's probe
function. So it's enough if mapped_irq is a local variable, and can be
dropped from driver data.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/20250109090802.3763275-2-u.kleine-koenig@baylibre.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 65b3aacf

drivers/gpio/gpio-altera.c

+4 −5
Original line number Diff line number Diff line
@@ -32,14 +32,12 @@ 
*			  will be blocked until the current one completes.

* @interrupt_trigger	: specifies the hardware configured IRQ trigger type

*			  (rising, falling, both, high)

* @mapped_irq		: kernel mapped irq number.

*/

struct altera_gpio_chip {

	struct gpio_chip gc;

	void __iomem *regs;

	raw_spinlock_t gpio_lock;

	int interrupt_trigger;

	int mapped_irq;

};



static void altera_gpio_irq_unmask(struct irq_data *d)
@@ -235,6 +233,7 @@ static int altera_gpio_probe(struct platform_device *pdev) 
	int reg, ret;

	struct altera_gpio_chip *altera_gc;

	struct gpio_irq_chip *girq;

	int mapped_irq;



	altera_gc = devm_kzalloc(&pdev->dev, sizeof(*altera_gc), GFP_KERNEL);

	if (!altera_gc)
@@ -271,8 +270,8 @@ static int altera_gpio_probe(struct platform_device *pdev) 
	if (IS_ERR(altera_gc->regs))

		return dev_err_probe(dev, PTR_ERR(altera_gc->regs), "failed to ioremap memory resource\n");



	altera_gc->mapped_irq = platform_get_irq_optional(pdev, 0);

	if (altera_gc->mapped_irq < 0)

	mapped_irq = platform_get_irq_optional(pdev, 0);

	if (mapped_irq < 0)

		goto skip_irq;



	if (device_property_read_u32(dev, "altr,interrupt-type", &reg)) {
@@ -296,7 +295,7 @@ static int altera_gpio_probe(struct platform_device *pdev) 
		return -ENOMEM;

	girq->default_type = IRQ_TYPE_NONE;

	girq->handler = handle_bad_irq;

	girq->parents[0] = altera_gc->mapped_irq;

	girq->parents[0] = mapped_irq;



skip_irq:

	ret = devm_gpiochip_add_data(dev, &altera_gc->gc, altera_gc);